sonatype-lift[bot] commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1013203543
##########
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
##########
@@ -154,14 +158,9 @@ public synchronized SolrClient getSolrClient() {
* options.
*/
public SolrClient createNewSolrClient() {
- try {
- // setup the client...
- final String url = jetty.getBaseUrl().toString() + "/" + "collection1";
- final SolrClient client = getHttpSolrClient(url,
DEFAULT_CONNECTION_TIMEOUT);
- return client;
- } catch (final Exception ex) {
- throw new RuntimeException(ex);
- }
+ // setup the client...
+ final SolrClient client = getHttpSolrClient(getServerUrl(),
DEFAULT_CONNECTION_TIMEOUT);
Review Comment:
*THREAD_SAFETY_VIOLATION:* Unprotected write. Non-private method
`SolrJettyTestBase.createNewSolrClient()` indirectly mutates container
`util.ObjectReleaseTracker.OBJECTS` via call to `Map.put(...)` outside of
synchronization.
Reporting because another access to the same memory occurs on a background
thread, although this access may not.
---
<details><summary><b>âšī¸ Learn about @sonatype-lift commands</b></summary>
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.</sub></details>
---
Was this a good recommendation?
[ [đ Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=350588764&lift_comment_rating=1)
] - [ [đ Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=350588764&lift_comment_rating=2)
] - [ [đ Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=350588764&lift_comment_rating=3)
] - [ [đ Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=350588764&lift_comment_rating=4)
] - [ [đ Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=350588764&lift_comment_rating=5)
]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
