epugh commented on code in PR #1158: URL: https://github.com/apache/solr/pull/1158#discussion_r1011897088
########## solr/solrj/src/test/org/apache/solr/client/solrj/TestBatchUpdate.java: ########## @@ -46,24 +46,28 @@ public static void beforeTest() throws Exception { @Test public void testWithXml() throws Exception { - HttpSolrClient client = (HttpSolrClient) getSolrClient(); - client.setRequestWriter(new RequestWriter()); + client = Review Comment: there is a ``` @After public synchronized void afterClass() throws Exception { if (client != null) client.close(); client = null; } ``` There doesn't appear to be any one pattern... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org