joshgog commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1009450598
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -3235,6 +3236,14 @@ private static boolean isChildDoc(Object o) {
return o instanceof SolrInputDocument;
}
+ public static String getUrlFrom(SolrClient solrClient) {
+ if (solrClient instanceof HttpSolrClient) {
+ return ((HttpSolrClient) solrClient).getBaseURL();
+ } else {
+ return null;
Review Comment:
> I _guess_ maybe if you had random types of `SolrClient` being created you
would need an else?
If its ok to add `getBaseURL()` method to other clients, I intend to use
else if statements to check `instanceOf `other clients and the final `else
`statement to raise an exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
