epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1009414092
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -3235,6 +3236,14 @@ private static boolean isChildDoc(Object o) {
return o instanceof SolrInputDocument;
}
+ public static String getUrlFrom(SolrClient solrClient) {
+ if (solrClient instanceof HttpSolrClient) {
+ return ((HttpSolrClient) solrClient).getBaseURL();
+ } else {
+ return null;
Review Comment:
I *think* that this should raise an exception, not a null... since it's
test code, we wouldn't ever call this where a null would make sense? I
*guess* maybe if you had random types of `SolrClient` being created you would
need an else? Right now however that owuldn't happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
