epugh commented on code in PR #1039: URL: https://github.com/apache/solr/pull/1039#discussion_r978126733
########## gradle/validation/error-prone.gradle: ########## @@ -74,17 +74,14 @@ allprojects { prj -> '-Xep:StaticAssignmentInConstructor:OFF', // we assign SolrTestCaseJ4.configString in many tests, difficult to untangle '-Xep:ComparableType:OFF', // SolrTestCaseJ4.Doc and Fld are messy - '-Xep:AlmostJavadoc:OFF', Review Comment: I like that in Rubocop, each rule is added to the list and is either set to on or off, so you can see everything you are enforcing, versus having things that aren't listed as being ON. This is totally a stylistic thing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org