risdenk commented on PR #1039: URL: https://github.com/apache/solr/pull/1039#issuecomment-1275052269
> It'd help reviewing if you did the work in separate commits. That way I could look at the commits and maybe review some commits of interest to me. > For example inlining deprecated methods on SolrException could have been its own commit. This in particular feels different in nature from the other changes that it should be in some other PR, actually. yea will admit got a bit overzealous fixing things in some of these files. I'll see if I can clean it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
