epugh opened a new pull request, #924: URL: https://github.com/apache/solr/pull/924
https://issues.apache.org/jira/browse/SOLR-16276 # Description IntelliJ flags redundant variables... Sometimes this is a redundency that helps explain the test, so you would want that. Sometimes it's a magic number (looking at you timeout variables!) that are always the same, and often it would flag a code path that was never actually traversed (looking at you null's passed into parameters or boolean values). # Solution Review and made judgement calls. This PR is ripe for bikeshedding, so please holler if you don't like one of the changes and I'll roll it back ;-). # Tests Ran tests # Checklist Please review the following and check all that apply: - [ x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ x] I have created a Jira issue and added the issue ID to my pull request title. - [ x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ x] I have developed this patch against the `main` branch. - [ x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
