cpoerschke commented on code in PR #921:
URL: https://github.com/apache/solr/pull/921#discussion_r908701519


##########
solr/core/src/test/org/apache/solr/update/AddBlockUpdateTest.java:
##########
@@ -103,6 +102,7 @@ public class AddBlockUpdateTest extends SolrTestCaseJ4 {
   @BeforeClass
   public static void beforeClass() throws Exception {
     String oldCacheNamePropValue = 
System.getProperty("blockJoinParentFilterCache");
+    boolean cachedMode;
     System.setProperty(
         "blockJoinParentFilterCache",
         (cachedMode = random().nextBoolean()) ? "blockJoinParentFilterCache" : 
"don't cache");

Review Comment:
   ```suggestion
       final boolean cachedMode = random().nextBoolean();
       System.setProperty(
           "blockJoinParentFilterCache",
           cachedMode ? "blockJoinParentFilterCache" : "don't cache");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to