epugh opened a new pull request, #921: URL: https://github.com/apache/solr/pull/921
…ate in nature, they dont help you understand how the test works https://issues.apache.org/jira/browse/SOLR-16224 # Description In the unit tests we have variables defined at the class level that don't actually need to be as they are used in a single method. However defining these at the top of the class CAN be helpful to understand the unit test. Having said that, there are some really boilerplate parameters that aren't specific to any individual test's behavior, like `tmpSolrHome`. # Solution Review the variables defined at the class level and if they don't help you understand the unit test, then move them to a method variable. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ X] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
