smoldenhauer-ish commented on PR #831:
URL: https://github.com/apache/solr/pull/831#issuecomment-1118255948

   I am still confused about the makePath I think the touchConfDir was only 
called/callable with an already existing configset node.
   I would like to avoid the throw - catch as I think it is bad in performance 
& style.
   I kindly suggest to use "{}".getBytes(StandardCharsets.UTF_8) as data 
instead of the 0 byte - because json is expected as data at the node later on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to