smoldenhauer-ish commented on PR #831: URL: https://github.com/apache/solr/pull/831#issuecomment-1116975365
Hi, @risdenk I had only a short look. Tests are much better now. I am not sure about the makePath vs setData Looks to me as there is a AlreadyExistsException is thrown and catched each time the touchConfDir is called. So i think that it does not "touch" the dir for whatever reason that "touch" is or was needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
