[ 
https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508154#comment-17508154
 ] 

Jan Høydahl commented on SOLR-15342:
------------------------------------

Now that SOLR-16061 is done, this is one step closer. But to fully isolate a 
solrj-zookeeper module/jar in 9.x, the classes depending on Zookeeper should be 
moved to separate packages. This should ideally affect mostly internal classes 
and hopefully few APIs we view as public for client-side use.

Turns out that ZookeeperException and ZkStateReader have sneaked in many 
places. One would expect the {{ClusterState}} object to be a pure data class, 
produced by some ClusterStateProvider, but turns out that {{ClusterState}} 
itself not only has a dependency on {{KeeperException}}, but also several 
{{ZkStateReader}} constants. ClusterState also has [a 
method|https://github.com/apache/solr/blob/main/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java#L243]
 that takes {{SolrZkClient}} as argument, and it depends on fromJson method in 
{{org.apache.solr.common.util.Utils}} which is a class that depends on 
Zookeeper.

The {{BaseHttpClusterStateProvider}} strangely depends on {{ZkStateReader}}, 
but only for a constant.

I'll try to get rid of the dependencies due to constants in SOLR-16106

> Separate out a SolrJ-Zookeeper module
> -------------------------------------
>
>                 Key: SOLR-15342
>                 URL: https://issues.apache.org/jira/browse/SOLR-15342
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: David Smiley
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Let's create a new "SolrJ-Zookeeper" module by refactoring out the ZooKeeper 
> related code out of the existing SolrJ module.  This allows clients that 
> don't want to talk to ZooKeeper to use the SolrJ module without transitive 
> dependencies for ZooKeeper or Netty (Netty is used by ZK for SSL).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to