[ 
https://issues.apache.org/jira/browse/SOLR-15342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495068#comment-17495068
 ] 

Jan Høydahl commented on SOLR-15342:
------------------------------------

[~haythemkh] I looked at the PR and it looks really promising, good work.

Unfortunately, since it touches 262 source files (mainly due to the smart 
{{ZkStateReader#from}} trick), it qucikly gets out of sync with main. Many 
large refactorings have happened the last few weeks.

Looks like the solrj refactorings are not going to make it for the 9.0 release. 
But would be great to see it happend in 9.1 or 9.2. To make that back-compat, I 
propose we do as outlined in my comment above, but perhaps stop shipping the 
"solr-solrj" artifact, but instead have
 * solr-solrj-all-<ver>.jar
 * solr-solrj-core-<ver>.jar
 * solr-solrj-zookeeper-<ver>.jar
 * solr-solrj-<foo>-<ver>.jar

This way, users upgrading to 9.0 cannot just upgrade the version in their 
application pom to 9.0.0 and expect things to work. They will need to make a 
choice of either solr-solrj-core for the bare-bones few-deps lib or 
solr-solrj-all for the [bloated 
thing|https://mvnrepository.com/artifact/org.apache.solr/solr-solrj/8.11.1] we 
force on them today.

> Separate out a SolrJ-Zookeeper module
> -------------------------------------
>
>                 Key: SOLR-15342
>                 URL: https://issues.apache.org/jira/browse/SOLR-15342
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrJ
>            Reporter: David Smiley
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Let's create a new "SolrJ-Zookeeper" module by refactoring out the ZooKeeper 
> related code out of the existing SolrJ module.  This allows clients that 
> don't want to talk to ZooKeeper to use the SolrJ module without transitive 
> dependencies for ZooKeeper or Netty (Netty is used by ZK for SSL).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to