risdenk commented on a change in pull request #688:
URL: https://github.com/apache/solr/pull/688#discussion_r813069936



##########
File path: solr/server/scripts/cloud-scripts/snapshotscli.sh
##########
@@ -11,7 +11,7 @@ run_solr_snapshot_tool() {
     log4j_config="file:${scriptDir}/../../resources/log4j2-console.xml"
   fi
   PATH=${JAVA_HOME}/bin:${PATH} ${JVM} ${ZKCLI_JVM_FLAGS} 
-Dlog4j.configurationFile=${log4j_config} \
-  -classpath "${solrLibPath}" org.apache.solr.core.snapshots.SolrSnapshotsTool 
"$@" 2> /dev/null
+  -classpath "${solrLibPath}" org.apache.solr.hdfs.snapshots.SolrSnapshotsTool 
"$@" 2> /dev/null

Review comment:
       So its not just a compile time dependency on `Path` - if you read the 
code there are tons of references to HDFS and distcp. Basically for snapshots 
to work you need a shared filesystem and HDFS is one of the only ones that 
works semi easily. But yea agree about backup-restore and if snapshots still is 
needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to