HoustonPutman commented on a change in pull request #688:
URL: https://github.com/apache/solr/pull/688#discussion_r813066227
##########
File path:
solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc
##########
@@ -452,7 +452,7 @@ An example configuration using these properties can be
found below:
[source,xml]
----
<backup>
- <repository name="hdfs"
class="org.apache.solr.core.backup.repository.HdfsBackupRepository"
default="false">
+ <repository name="hdfs"
class="org.apache.solr.hdfs.backup.repository.HdfsBackupRepository"
default="false">
Review comment:
We need to add this in the `major-changes-in-solr-9.adoc`
##########
File path: solr/server/scripts/cloud-scripts/snapshotscli.sh
##########
@@ -11,7 +11,7 @@ run_solr_snapshot_tool() {
log4j_config="file:${scriptDir}/../../resources/log4j2-console.xml"
fi
PATH=${JAVA_HOME}/bin:${PATH} ${JVM} ${ZKCLI_JVM_FLAGS}
-Dlog4j.configurationFile=${log4j_config} \
- -classpath "${solrLibPath}" org.apache.solr.core.snapshots.SolrSnapshotsTool
"$@" 2> /dev/null
+ -classpath "${solrLibPath}" org.apache.solr.hdfs.snapshots.SolrSnapshotsTool
"$@" 2> /dev/null
Review comment:
The only hdfs specific dependency I see is Path... Is the commons-cli a
transative dependency there? In general I'm not sure how useful this tool is
now that the backup-restore functionality is really good, but I guess that's
for a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
