risdenk commented on a change in pull request #636:
URL: https://github.com/apache/solr/pull/636#discussion_r809406423
##########
File path:
solr/core/src/java/org/apache/solr/core/snapshots/SolrSnapshotsTool.java
##########
@@ -227,12 +227,12 @@ public void describeSnapshot(String collectionName,
String snapshotName) {
String indexDirPath = coreSnap.getIndexDirPath();
if (pathPrefix != null) {
// If the path prefix is specified, rebuild the path to the index
directory.
- indexDirPath = new Path(pathPrefix,
coreSnap.getIndexDirPath()).toString();
+ indexDirPath = Path.of(pathPrefix,
coreSnap.getIndexDirPath()).toString();
}
List<String> paths = new ArrayList<>();
for (String fileName : coreSnap.getFiles()) {
- Path p = new Path(indexDirPath, fileName);
+ Path p = Path.of(indexDirPath, fileName);
Review comment:
I looked at this closer and think I'm going to move `SolrSnapshotsTool`
to the hdfs module. This change neuters the hdfs part which is pretty core to
this tool. The move will at least keep it around and working - since all the
other HDFS implementation is in the hdfs module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
