risdenk commented on a change in pull request #637: URL: https://github.com/apache/solr/pull/637#discussion_r806406106
########## File path: solr/modules/sql/build.gradle ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'SQL Module' + +dependencies { + implementation project(':solr:core') + implementation project(':solr:solrj') + + implementation 'org.slf4j:slf4j-api' + + implementation 'com.google.guava:guava' + + // SQL Parser via Calcite + implementation ('org.apache.calcite:calcite-core', { + exclude group: 'org.apache.calcite.avatica', module: 'avatica-metrics' + exclude group: 'com.google.guava', module: 'guava' // TODO remove this to keep versions in sync Review comment: @sonatype-lift ignore ########## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java ########## @@ -1298,6 +1298,16 @@ public static ModifiableSolrParams params(String... params) { return Utils.makeMap(params); } + public static SolrParams mapParams(String... vals) { Review comment: Yea I want to make this change outside of this PR. `mapParams` is being used across classes for no good reason. I agree it needs to move somewhere and its a weird method. I'll see where else in `test-framework` makes sense. ########## File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java ########## @@ -1298,6 +1298,16 @@ public static ModifiableSolrParams params(String... params) { return Utils.makeMap(params); } + public static SolrParams mapParams(String... vals) { Review comment: Created https://issues.apache.org/jira/browse/SOLR-16012 to do this separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
