dsmiley commented on a change in pull request #637:
URL: https://github.com/apache/solr/pull/637#discussion_r806406756
##########
File path: gradle/validation/spotless.gradle
##########
@@ -53,6 +53,7 @@ configure(project(":solr").subprojects) { prj ->
case ":solr:modules:langid":
case ":solr:modules:ltr":
case ":solr:modules:scripting":
+ case ":solr:modules:sql":
Review comment:
As I've reminded others, lets please disassociate automatic source code
formatting with moving code into a module. By disassociating them, we can
point to a commit that can be excluded from history that *only* does formatting
and not anything else. These go in `.git-blame-ignore-revs`
##########
File path: solr/core/build.gradle
##########
@@ -153,22 +153,6 @@ dependencies {
implementation 'org.codehaus.woodstox:stax2-api'
implementation 'com.fasterxml.woodstox:woodstox-core'
- // SQL Parser via Calcite
Review comment:
Huzzah!
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
##########
@@ -1298,6 +1298,16 @@ public static ModifiableSolrParams params(String...
params) {
return Utils.makeMap(params);
}
+ public static SolrParams mapParams(String... vals) {
Review comment:
Please let's not pollute SolrTestCaseJ4 with this needless method.
STCJ4 is out of control and I feel the need to be a policeman. See the
existing `params` method. The addition of javabin randomly is weird. I
understand you are just trying to move this module and you didn't write this
code... so move it somewhere else or consider if it's maybe not useful to
randomly alter the response format.
##########
File path: solr/modules/sql/README.md
##########
@@ -0,0 +1,29 @@
+Apache Solr SQL Module
+===============================
+
+Introduction
+------------
+This module implements the support for SQL in Apache Solr.
+
+Building
+--------
+The SQL module uses the same Gradle build as the core Solr components.
+
+To build the module, you can use
+
+```
+./gradlew :solr:modules:sql:assemble
+```
+
+The resulting module will be placed to the libs directory, for example:
+`solr/modules/hdfs/build/libs/solr-sql-9.0.0-SNAPSHOT.jar`
+
+To execute the module tests:
+
+```
+./gradlew :solr:modules:sql:test
+```
+
+Usage
+-----
+Please refer to the 'Running Solr on HDFS' section of the reference guide:
https://solr.apache.org/guide/running-solr-on-hdfs.html
Review comment:
Guilty of copy-pasting ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
