dsmiley commented on a change in pull request #580: URL: https://github.com/apache/solr/pull/580#discussion_r797970632
########## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ########## @@ -2284,8 +2285,10 @@ public void run() { SolrCore core; while (!container.isShutDown() && (core = solrCores.getCoreToClose()) != null) { + assert core.getOpenCount() == 1; Review comment: The closer thread only operates on cores that have already been removed from access (e.g. to be opened for a new query). And a request to open it (transiently?) will block because this queue is considered in `SolrCores.pendingCoreOps` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org