dsmiley commented on a change in pull request #580:
URL: https://github.com/apache/solr/pull/580#discussion_r797605216
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -2084,12 +2084,13 @@ public boolean isLoaded(String name) {
return solrCores.isLoaded(name);
}
- public boolean isLoadedNotPendingClose(String name) {
- return solrCores.isLoadedNotPendingClose(name);
+ /** The core is loading, unloading, or reloading. */
+ boolean hasPendingCoreOps(String name) {
Review comment:
I'd prefer the reverse -- don't even have it on CoreContainer but
weirdly the transient core cache doesn't have access to SolrCores despite it
being intertwined with it. On our massive codebase, I'd prefer we be mindful
of the use of "public".
##########
File path: solr/core/src/java/org/apache/solr/core/SolrCores.java
##########
@@ -377,6 +370,12 @@ protected CoreDescriptor getUnloadedCoreDescriptor(String
cname) {
}
}
+ boolean hasPendingCoreOps(String name) {
Review comment:
SolrCores isn't sub-classed. I suspect you asked this because the use
of protected is pervasive across other methods here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
