dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r789214464
##########
File path:
solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
##########
@@ -66,27 +70,19 @@ public void testLogLevelHandlerOutput() throws Exception {
config.getLoggerConfig(PARENT_LOGGER_NAME));
assertEquals(Level.DEBUG,
config.getLoggerConfig(CLASS_LOGGER_NAME).getLevel());
- assertQ("Show Log Levels OK",
- req(CommonParams.QT,"/admin/logging")
-
,"//arr[@name='loggers']/lst/str[.='"+CLASS_LOGGER_NAME+"']/../str[@name='level'][.='DEBUG']"
-
,"//arr[@name='loggers']/lst/str[.='"+PARENT_LOGGER_NAME+"']/../null[@name='level']"
- );
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
+ ModifiableSolrParams mparams = new ModifiableSolrParams();
+ mparams.set("set", PARENT_LOGGER_NAME + ":TRACE");
+ client.request(new GenericSolrRequest(SolrRequest.METHOD.GET,
"/admin/info/logging", mparams));
- assertQ("Set a (new) level",
Review comment:
AFAICT, the purpose of these assertions is to assert the response of
getting the log levels from Solr. Your changes removed that; thus it's
untested (right?). It should be tested to protect against regressions in the
format or what levels are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
