dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r787072050
##########
File path:
solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -61,9 +64,11 @@ public void testDisabledRedaction() throws Exception {
@SuppressWarnings({"unchecked"})
private NamedList<Object> readProperties() throws Exception {
- SolrQueryResponse rsp = new SolrQueryResponse();
- SolrQueryRequest req = req();
-
h.getCoreContainer().getInfoHandler().getPropertiesHandler().handleRequestBody(req,
rsp);
- return (NamedList<Object>) rsp.getValues().get("system.properties");
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
Review comment:
Great!
And can you also use this approach for the other tests you added? At least
I think you added some that could use this technique; I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
