uschindler edited a comment on pull request #501:
URL: https://github.com/apache/solr/pull/501#issuecomment-1011150139


   > Maven coordinates only exist in maven. Gradle has module paths - build 
inclusion is kind of hacking these two worlds together. What's in that file is 
a result of trial-and-error and my understanding of how these two worlds come 
together, I'm by no means trying to say I understand everything going on under 
the hood of Gradle...
   
   That's not fully true. In the documentation it states @ [Cases where 
included build substitutions must be 
declared](https://docs.gradle.org/current/userguide/composite_builds.html#included_build_substitution_requirements):
 "When the maven-publish or ivy-publish plugins are used for publishing, and 
the publication coordinates don’t match `${project.group}:${project.name}` ... 
When the `archivesBaseName` property is used to set the name of the published 
artifact."
   
   We don't set `project.group` and `project.name` anywhere in our build system 
and the automatic name (from directory name) differs from the Maven artifact 
name, unfortunately. We use `archivesBaseName` instead. The group is only 
assigned during publishing. If we would do this (we already state 
`project.description`in every build.gradle and we set the version) and use the 
archivesBaseName also as gradle project name, then it would work fully 
automatic.
   
   In short if we would set `project.name` with our artifact name and 
`project.group="org.apache.solr"` then it would work. Description for Maven is 
also inherited from there. We don't need to change this, but I was stumbling on 
this discrepancy already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to