uschindler commented on pull request #501: URL: https://github.com/apache/solr/pull/501#issuecomment-1009954187
> This looks really good. I'm not going to test this locally myself, but I can change the luceneMatchVersion inserted into solrconfig.xml to Major.Minor. Wehenver you guys says it's ready I can then merge and backport. All fine. About the 9.0.0 vs. 9.0 I am not fully sure. In the past we changed this on every version, so the current state with full version is fine, although it is not needed for config file sanity (IMHO there we should only use x.y versions). When executing tests it does not matter which version we pass, we can use full version, too. It obly must be in the digit-only format, so we have to remove any appendixes. My proposal would be: read the version as done currently and sanitize to x.y.z. Pass this to tests, but the config files shipped with release should use the x.y version to make it easier for users to understand that only this is needed for "correct config files". This check should be adapted in the config file checker. But maybe that's a separate issue, isn't it? > (I have hacked a cherrypick.sh script that I want to test out, streamlining backporting of trivial, non-conflicting changes) 😁 I use TortoiseGit for cherrypicking. Thats grandious: Open the log window on 9.x/9.0 checkout, switch branch in log window to show main, select commit, right click, cherry-pick (also works with multiple). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
