janhoy commented on pull request #491:
URL: https://github.com/apache/solr/pull/491#issuecomment-1006131673


   > @janhoy, there is an issue with the new distribution. I believe this 
"create a directory, then make a tarball" approach was used initially, however 
it caused the files to lose permissions (i.e. no executable flags that had been 
set). This was fixed when we went straight into a tarball from sources, setting 
the necessary permissions.
   
   Good catch. This will also make the image smaller, right?
   
   I wanted to migrate to the better organization from Lucene, thus the 
"distribution" folder. But at the same time I did not want to disrupt the 
existing dev workflow that is documented, so I kept the assembly of the binary 
directory as-is.
   
   Perhaps the "distribution" `assembleBinaryTgz` can re-assemble the files on 
the fly instead of copying from the pre-built folder? Are you saying the old 
assembly in "packaging" did that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to