janhoy commented on pull request #491: URL: https://github.com/apache/solr/pull/491#issuecomment-1006127622
Thanks @HoustonPutman. There is still a problem I'm tackling, which is that a plain `gradlew assembleRelease` without signing, now does not work since we're always triggering officia dockerfile build, which throws exception if not signed.: ``` > gradlew clean assembleRelease Using gradle at '/Users/janhoy/git/solr/gradlew' to run buildfile '/Users/janhoy/git/solr/build.gradle': FAILURE: Build failed with an exception. * Where: Build file '/Users/janhoy/git/solr/solr/docker/build.gradle' line: 338 * What went wrong: No GPG keyName found, please see help/publishing.txt (GPG key is neccessary to create Dockerfile.official) * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 2s 2 actionable tasks: 2 up-to-date ``` A simple solution is to skip the official file if no signing, so folks can test out a local tgz build. During a release there will always be signing, so then we'll include the official. I have a patch up (just need to modify it for your latest commit :) ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org