mkhludnev commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-963105309
Sigh.. It seems `SRI.closed` can't be introduced. If a request thread spins off `MDCAwareThreadPool` it's not obvious who should close `SRI`. In master branch, it's closed twice. In this branch it's closed in the request thread. The problem that request thread might close it before it will be used in thread pool. At least it's what happen in code right now. It may make harm some cases, but it's out of scope of this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
