dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-950013908
I wasn't correct about Janino needing to be excluded... I hadn't noticed it's sha1 change in another change group in IntellliJ. I'm confused about `versions.props`. I thought this pinned our versions but it seems not because this is what is in there: ``` org.codehaus.janino:*=3.0.9 ``` Yet Gradle selected 3.0.11. FYI this is also why I excluded Guava from Calcite-core because it would have upgraded the Guava version we use. (BTW Calcite's website claims a wide range of Guava compatibility and so there is no concern there). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
