dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-949042358
I made further improvements, especially in SolrJ. There is one mystery to me. The license & sha1 check system told me to remove the ones for Janino but I didn't remove Janino; it's merely a transitive dependency now (via Calcite-core). * org.codehaus.janino:janino:3.0.11 * | \--- org.codehaus.janino:commons-compiler:3.0.11 WEB-INF/lib has these. I hope we're fine here without a JIRA issue. My rationale is that this is just a refactoring. I set out for the dependencies to be the same in the end but there are a couple minor tweaks I'm aware of as evidenced in this PR -- kerby-kdc isn't needed (transitive to Hadoop stuff), nor is eigenbase-properties (transitive to Calcite stuff). I suspect these were dependencies that may have been required at some point but after an upgrade and now aren't, or maybe they never were. Tests pass -- hopefully a good enough check. We have other transitive dependencies from Calcite that I suspect we don't need either (protobuf and esri stuff) that I could exclude but didn't because my objective here is not to go pruning the project's dependencies, yet I admit I in effect did this with two above. So; should I declare explicit dependencies to bring back what we might not need, leaving pruning for another issue that could have a bigger scope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
