janhoy commented on a change in pull request #313:
URL: https://github.com/apache/solr/pull/313#discussion_r718350709
##########
File path: solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
##########
@@ -146,6 +146,7 @@ public void testSortingMPSolrIndexConfigCreation() throws
Exception {
final Sort expected = new Sort(new SortField(expectedFieldName,
expectedFieldType, expectedFieldSortDescending));
final Sort actual = sortingMergePolicy.getSort();
assertEquals("SortingMergePolicy.getSort", expected, actual);
+ assertEquals("indexSort", expected, iwc.getIndexSort());
Review comment:
Ok, perhaps they are R/O because it is not supported to change these
after collection creation?
In that case, a new xml file is probably better anyway.
Are you planning to validate that index sorting is working in the test, or
simply that the config is set? I think perhaps a new method in the existing
IndexConfig test would be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
