[ 
https://issues.apache.org/jira/browse/SOLR-15644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419013#comment-17419013
 ] 

Dawid Weiss edited comment on SOLR-15644 at 9/23/21, 7:55 AM:
--------------------------------------------------------------

bq. It’s slow because it’s generic and because what you interrupt and when and 
whether and how you retry matters a lot.

Can you enlighten me and be more specific? How does the PR address the above 
"non-generic" cases? interruptThreadsOnTearDown is a generic loop setting an 
interrupt flag for all of the thread group's threads.


was (Author: dweiss):
bq. It’s slow because it’s generic and because what you interrupt and when and 
whether and how you retry matters a lot.

Can you enlighten me and be more specific? How does the PR address the above 
"non-generic" interrupts? interruptThreadsOnTearDown is a generic loop setting 
an interrupt flag for all of the thread group's threads.

> Add the ability to interrupt and wait for threads for problematic tests.
> ------------------------------------------------------------------------
>
>                 Key: SOLR-15644
>                 URL: https://issues.apache.org/jira/browse/SOLR-15644
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mark Robert Miller
>            Assignee: Mark Robert Miller
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The stuff in the test framework is slow and lacks control. For problematic 
> tests, you don't want to linger first and you want fine control around 
> interrupting - interrupting with a sledgehammer approach can actually make 
> things take longer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to