[
https://issues.apache.org/jira/browse/SOLR-15644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419004#comment-17419004
]
Dawid Weiss edited comment on SOLR-15644 at 9/23/21, 7:40 AM:
--------------------------------------------------------------
bq. The stuff in the test framework is slow and lacks control.
It's not slow at all but it's currently configured with 10s lingering timeout
for Solr tests...
https://github.com/apache/solr/blob/main/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java#L64
And even longer timeouts for Lucene:
https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java#L197-L201
The hand-rolled version in your PR does roughly the same thing as the code in
the RR (but it manually repeats what's in ignored threads filters, etc.). I'm
not sure why it works faster for you.
https://github.com/randomizedtesting/randomizedtesting/blob/8be8a09e3b3bf1a57947d5367a1afe68322ac4dc/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/ThreadLeakControl.java#L768-L792
was (Author: dweiss):
bq. The stuff in the test framework is slow and lacks control.
It's not slow at all but it's currently configured with 10s lingering timeout
for Solr tests...
https://github.com/apache/solr/blob/main/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java#L64
And even longer timeouts for Lucene:
https://github.com/apache/lucene/blob/main/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java#L197-L201
The hand-rolled version in your PR does roughly the same thing as the code in
the RR (but it manually repeats what's in ignored threads filters, etc.). I'm
not sure why it works faster to you.
https://github.com/randomizedtesting/randomizedtesting/blob/8be8a09e3b3bf1a57947d5367a1afe68322ac4dc/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/ThreadLeakControl.java#L768-L792
> Add the ability to interrupt and wait for threads for problematic tests.
> ------------------------------------------------------------------------
>
> Key: SOLR-15644
> URL: https://issues.apache.org/jira/browse/SOLR-15644
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The stuff in the test framework is slow and lacks control. For problematic
> tests, you don't want to linger first and you want fine control around
> interrupting - interrupting with a sledgehammer approach can actually make
> things take longer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
