[ https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399307#comment-17399307 ]
Mark Robert Miller edited comment on SOLR-15428 at 8/15/21, 6:23 AM: --------------------------------------------------------------------- I think if Uwe took to rebuilding/redesigning everything he was “not a big fan of” he would quickly drown in the back log. And he is incapable of defending a system without expressing everything he would do differently. He simply doesn’t understand the story of those changes, given that any sensible German would surely only have gotten to them via full consideration and intention. The reality is, I popped that plug-in in just to try it out and see if maybe we’d use it because it took one second and then I mostly forgot about it. It’s pretty meh, because the JMH Visualizer website is Uber simple and quick and shareable and supports multiple result file comparisons. There is also a Jenkins plugin that also supports multiple file result comparisons. I don’t even use the plugin, just tried it the once. And then for the compile task, I did once have another target because I could jot figure out why the heck annotation processors didn’t work with the default. Eventually I found the place that removes proc, and I tried to simply diverge less from the build by just allowing the proc setting. But I’m not really familiar with the rest of the build and by then I’d have enough fiddling with something so simple that was so annoying to get working to explore much further. And then I’m working through forbidden apis. After satisfying like a 100 tiny build checks, and it’s scanning the build folder for Java src files. I found ignore much faster than that exclude and didn’t have much care for its policing on this dev code. So I worked through like 200 tiny things, told forbidden to take a hike, worked around the lack of proc as minimally as seemed to not cause me any grief and left in a “hmm, who knows” try once plug-in explore. It’s not very German, so Uwe is like, Christ, it’s a build subversion attempt. Someone is trying to hack towards my internally preferred design. I understand why, but totally illegal. Meh. I’d feel I wasted way too much time if I added a new module and didn’t leave something for Uwe. was (Author: markrmiller): I think of Uwe took to rebuilding/redesigning everything he was “not a big fan of” he would quickly drown in the back log. And he is incapable of defending a system without expressing everything he would do differently. He simply doesn’t understand the story of those changes, given that any sensible German would surely only have gotten to them via full consideration and intention. The reality is, I popped that plug-in in just to try it out and see if maybe we’d use it because it took one second and then I mostly forgot about it. It’s pretty meh, because the JMH Visualizer website is Uber simple and quick and shareable and supports multiple result file comparisons. There is also a Jenkins plugin that also supports multiple file result comparisons. I don’t even use the plugin, just tried it the once. And then for the compile task, I did once have another target because I could jot figure out why the heck annotation processors didn’t work with the default. Eventually I found the place that removes proc, and I tried to simply diverge less from the build by just allowing the proc setting. But I’m not really familiar with the rest of the build and by then I’d have enough fiddling with something so simple that was so annoying to get working to explore much further. And then I’m working through forbidden apis. After satisfying like a 100 tiny build checks, and it’s scanning the build folder for Java arc files. I found ignore much faster than that exclude and didn’t have much care for its policing on this dev code. So I worked through like 200 tiny things, told forbidden to take a hike, worked around the lack of proc as minimally as seemed to not cause me any grief and left in a “hmm, who knows” try once plug-in explore. It’s not very German, so Uwe is like, Christ, it’s a build subversion attempt. Someone is trying to hack towards my internally preferred design. I understand why, but totally illegal. Meh. I’d feel I wasted way too much time if I added a new module and didn’t leave something for Uwe. > Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and > performance comparisons and investigation. > ----------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-15428 > URL: https://issues.apache.org/jira/browse/SOLR-15428 > Project: Solr > Issue Type: New Feature > Reporter: Mark Robert Miller > Assignee: Mark Robert Miller > Priority: Major > Fix For: main (9.0) > > Attachments: bench.patch > > Time Spent: 9h 20m > Remaining Estimate: 0h > > I’ve spent a fair amount of time over the years on work around integrating > Lucene’s benchmark framework into Solr and while I’ve used this with > additional local work off and on, JMH has become somewhat of a standard for > micro benchmarks on the JVM. I have some work that provides an initial > integration, allowing for more targeted micro benchmarks as well as more > integration type benchmarking using JettySolrRunner. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org