[
https://issues.apache.org/jira/browse/SOLR-15428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398197#comment-17398197
]
Uwe Schindler edited comment on SOLR-15428 at 8/12/21, 5:32 PM:
----------------------------------------------------------------
bq. The plugin stuff was more about the Gradle build. Don't mix styles to
express things. Our current build system has a centralized view on modules and
inherits settings. Benchmark is just another module so it gets all checks like
forbiddenapis or ECJ or code formatters. But the configuration of those should
be in the plugin's config file not splattered around all files.
The javac settings with add/remove like you did it won't work with Gradle 7
anymore, so they have to be moved like I did. It is disallowed to change task
settings inside the execution phase, as it breaks caching. So a separate {{
configure \{....\} }} is easiest.
was (Author: thetaphi):
bq. The plugin stuff was more about the Gradle build. Don't mix styles to
express things. Our current build system has a centralized view on modules and
inherits settings. Benchmark is just another module so it gets all checks like
forbiddenapis or ECJ or code formatters. But the configuration of those should
be in the plugin's config file not splattered around all files.
The javac settings with add/remove like you did it won't work with Gradle 7
anymore, so they have to be moved like I did. It is disallowed to change task
settings inside the execution phase, as it breaks caching. So a separate
{{configure {....} }} is easiest.
> Integrate the OpenJDK JMH micro benchmark framework for micro benchmarks and
> performance comparisons and investigation.
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-15428
> URL: https://issues.apache.org/jira/browse/SOLR-15428
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: bench.patch
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> I’ve spent a fair amount of time over the years on work around integrating
> Lucene’s benchmark framework into Solr and while I’ve used this with
> additional local work off and on, JMH has become somewhat of a standard for
> micro benchmarks on the JVM. I have some work that provides an initial
> integration, allowing for more targeted micro benchmarks as well as more
> integration type benchmarking using JettySolrRunner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
