thelabdude commented on a change in pull request #219: URL: https://github.com/apache/solr/pull/219#discussion_r669644632
########## File path: solr/solrj/src/java/org/apache/solr/common/cloud/VMParamsAllAndReadonlyDigestZkACLProvider.java ########## @@ -30,6 +30,12 @@ public static final String DEFAULT_DIGEST_READONLY_USERNAME_VM_PARAM_NAME = "zkDigestReadonlyUsername"; public static final String DEFAULT_DIGEST_READONLY_PASSWORD_VM_PARAM_NAME = "zkDigestReadonlyPassword"; + + // fallback env vars if system props not set + public static final String ZK_ALL_ACL_USERNAME = "ZK_ALL_ACL_USERNAME"; + public static final String ZK_ALL_ACL_PASSWORD = "ZK_ALL_ACL_PASSWORD"; + public static final String ZK_READ_ACL_USERNAME = "ZK_READ_ACL_USERNAME"; + public static final String ZK_READ_ACL_PASSWORD = "ZK_READ_ACL_PASSWORD"; Review comment: will do! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org