thelabdude opened a new pull request #219: URL: https://github.com/apache/solr/pull/219
https://issues.apache.org/jira/browse/SOLR-15525 # Description Get zk acl username and/or password from either a Java sys prop (current behavior) or from an environment variable. The code now looks for the `env:` prefix on the Java sys prop value and if found, reads the value from the environment variable, such as: `-DzkDigestReadonlyPassword=env:SOME_ENV_VAR` will get the password from the env var named `SOME_ENV_VAR`. If Java sys prop not set, then we look for a fallback default env var, such as `ZK_READ_ACL_PASSWORD` # Solution Please provide a short description of the approach taken to implement your solution. # Tests Need to figure out a way to set env vars for testing w/o overcomplicating the impl. as in I don't like exposing `setEnvVars` like `EnvSSLCredentialProvider` did ... # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
