gerlowskija commented on pull request #190: URL: https://github.com/apache/solr/pull/190#issuecomment-870154214
This LGTM and is a huge step forward for the ref-guide! The biggest nitpick I probably have here is that the breaking up of the old "Admin UI" section (a change I'm hugely in favor of) leaves a few vestigial stub pages around as not very useful "screenshot-vehicles". e.g. thread-dump.adoc. It looks like most of the Admin UI content it looks like was able to be pulled into other pages, but the few places this couldn't be done feel awkward IMO. Not sure there's a fix to this though - short of individually adding conceptually related content to these pages. (In the thread-dump.adoc example, maybe someone will eventually add info there about Solr-specific things to look for in thread dumps). That said, I'm totally happy to live with this if it's a side effect of the otherwise overwhelmingly positive change. Will be great to see this in 9! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
