madrob commented on a change in pull request #169: URL: https://github.com/apache/solr/pull/169#discussion_r652110237
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/PutCacheEvaluator.java ########## @@ -37,18 +37,18 @@ public PutCacheEvaluator(StreamExpression expression, StreamFactory factory) thr } @Override - @SuppressWarnings({"unchecked", "rawtypes"}) public Object doWork(Object... values) throws IOException { - ConcurrentMap objectCache = this.streamContext.getObjectCache(); + ConcurrentMap<String, Object> objectCache = this.streamContext.getObjectCache(); if(values.length == 3) { String space = (String)values[0]; String key = (String)values[1]; space = space.replace("\"", ""); key = key.replace("\"", ""); Object value = values[2]; - ConcurrentMap spaceCache = (ConcurrentMap)objectCache.get(space); + @SuppressWarnings("unchecked") + ConcurrentMap<String, Object> spaceCache = (ConcurrentMap<String,Object>)objectCache.get(space); Review comment: I had a TODO in StreamContext that we should be able to be more specific about what objectCache contains, and went ahead and implemented that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org