cpoerschke commented on a change in pull request #169:
URL: https://github.com/apache/solr/pull/169#discussion_r652015016
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/GaussFitEvaluator.java
##########
@@ -81,7 +80,7 @@ public Object doWork(Object... objects) throws IOException{
double[] coef = curveFitter.fit(pointList);
Gaussian gaussian = new Gaussian(coef[0], coef[1], coef[2]);
- List list = new ArrayList();
+ List<Double> list = new ArrayList<>();
Review comment:
Yes, now that `VectorFunction` takes `List<? extends Number>` it's less
of an issue, before when it took `List<Number>` then clearly `List<Double>`
would work too but declaring `List<Number>` here seemed slightly clearer.
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/eval/KnnRegressionEvaluator.java
##########
@@ -71,6 +71,7 @@ public Object doWork(Object ... values) throws IOException {
observations = (Matrix)values[0];
} else if(values[0] instanceof List) {
bivariate = true;
+ @SuppressWarnings({"unchecked"})
Review comment:
minor: did you mean to perhaps remove the method-level
`@SuppressWarnings({"unchecked"})` at line 57 then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
