ctargett commented on a change in pull request #91: URL: https://github.com/apache/solr/pull/91#discussion_r644746888
########## File path: solr/solr-ref-guide/src/coreadmin-api.adoc ########## @@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it. If a Solr core with the given name already exists, it will continue to handle requests while the new core is initializing. When the new core is ready, it will take new requests and the old core will be unloaded. `admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data` +[.dynamic-tabs] +-- +[example.tab-pane#v1coreadmin-create] +==== +[.tab-label]*V1 API* + +Assuming you are using an existing configSet to create your new core: +[source,bash] +---- +http://localhost:8983/solr/admin/cores?action=CREATE&&name=techproducts_v2&configSet=sample_techproducts_configs + +---- + +If you have already existing core files deployed on disk, and need to just create the Solr core from them then the url will look something like +[source,bash] +---- +admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data +---- +==== + +[example.tab-pane#v2coreadmin-create] +==== +[.tab-label]*V2 API* + +Assumes SOLR-15372 is committed. Review comment: I agree with Jason. The Jira is only relevant to the example you've chosen to use, not the API, so the bug is completely irrelevant to the overall documentation of the API. ########## File path: solr/solr-ref-guide/src/schema-api.adoc ########## @@ -112,7 +93,7 @@ curl -X POST -H 'Content-type:application/json' --data-binary '{ "name":"sell_by", "type":"pdate", "stored":true } -}' http://localhost:8983/solr/gettingstarted/schema +}' http://localhost:8983/solr/techproducts/schema Review comment: Meh, I'm frankly -0 on changing every example to use techproducts. Sure it's an example we've always shipped, but I also think it's very limited. Not that I have any suggestions for alternatives, I just think there are 100 other things I'd rather do in the docs than spend time on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
