tomglk commented on a change in pull request #151:
URL: https://github.com/apache/solr/pull/151#discussion_r641771214
##########
File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java
##########
@@ -70,6 +72,63 @@ public void tearDown() throws Exception {
super.tearDown();
}
+ @Test
+ public void testSimpleQueryCustomSort() throws Exception {
+ SolrQuery query = new SolrQuery("*:*");
+ query.setRequestHandler("/query");
+ query.setFields("*,score,[shard]");
Review comment:
No worries, thank you for pointing out the fl, we did not consider that.
> query.setFields("*,score,[shard]");
query.setFields("*,[shard]");
That change actually broke the tests. We will look for a solution to that.
I think tests in the core package are a good idea. Instead of expanding
`DistributedQueryComponentCustomSortTest` an approach could be to add a new
`DistributedQueryComponentReRankTest` with `ShardsRepeat` instead of
`ShardsFixed`.
That way we could separate the two use cases of custom sort and reranking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
