[
https://issues.apache.org/jira/browse/SOLR-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340411#comment-17340411
]
David Smiley commented on SOLR-15389:
-------------------------------------
FWIW, I'm a fan of doing test assertions on toStrings of Queries (and generally
-- Maps or Lists or various things) because it's so readable and efficient to
read & write! Some manual query construction code in tests are verbose
monstrosities -- I've seen them and they leave a bad taste in my mouth.
The particular example above is maybe medium verbosity in my book... not too
bad but could get worse in other examples.
That said, do as you wish; I'm just expressing my opinion.
bq. maybe add some simple factory methods
Yes -- but to Lucene Queries! Like a new TermQuery constructor that took the
field and string value, for example. Like BooleanQuery.Builder gaining methods
like addShould addMust, addFilter, etc.
> Certain tests rely on DisjunctionMaxQuery clause order
> -------------------------------------------------------
>
> Key: SOLR-15389
> URL: https://issues.apache.org/jira/browse/SOLR-15389
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Priority: Major
>
> Broken by LUCENE-9940
> Test failures e.g.
> org.apache.solr.search.TestSolrQueryParser.testSynonymQueryStyle
> {noformat}
> org.junit.ComparisonFailure:
> <(t_pick_best_foo:[tabbi | t_pick_best_foo:cat | t_pick_best_foo:felin] |
> t_pick_best_foo:a...>
> <(t_pick_best_foo:[felin | t_pick_best_foo:cat | t_pick_best_foo:tabbi] |
> t_pick_best_foo:a...>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
