Kontinuation commented on code in PR #557:
URL: https://github.com/apache/sedona-db/pull/557#discussion_r2741893625


##########
c/sedona-extension/src/scalar_kernel.rs:
##########
@@ -560,6 +562,7 @@ impl ExportedScalarKernelImpl {
                     &args,
                     return_type,
                     num_rows as usize,
+                    None,

Review Comment:
   I agree that functions relying on options should fail instead of silently 
using default options. Let's keep using `Option<>` then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to