paleolimbot commented on code in PR #557:
URL: https://github.com/apache/sedona-db/pull/557#discussion_r2737891853
##########
c/sedona-extension/src/scalar_kernel.rs:
##########
@@ -560,6 +562,7 @@ impl ExportedScalarKernelImpl {
&args,
return_type,
num_rows as usize,
+ None,
Review Comment:
I like the `Option<>` but if there is no cost to constructing default
options that is OK too. If a Sedona UDF is specifically making use of options
it's probably better for it to error in the unlikely event it is FFIed by
accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
