paleolimbot commented on code in PR #381:
URL: https://github.com/apache/sedona-db/pull/381#discussion_r2573333452


##########
rust/sedona-testing/src/benchmark_util.rs:
##########
@@ -426,6 +464,7 @@ impl BenchmarkArgSpec {
         vertex_count: usize,
         num_parts_count: usize,
         rows_per_batch: usize,
+        polygon_hole_rate: Option<f64>,

Review Comment:
   This caused `clippy` to complain about too many arguments. While clippy *is* 
right here (the call to `build_geometry` is getting a bit unwieldy/unreadable), 
it's an internal function and it's well tested. You can add 
`#[allow(clippy::too_many_arguments)]` right above `fn build_geometry(` to fix 
the error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to