Abeeujah commented on code in PR #381:
URL: https://github.com/apache/sedona-db/pull/381#discussion_r2571561280
##########
rust/sedona-functions/benches/native-functions.rs:
##########
@@ -82,6 +82,21 @@ fn criterion_benchmark(c: &mut Criterion) {
benchmark::scalar(c, &f, "native", "st_hasm", Point);
benchmark::scalar(c, &f, "native", "st_hasm", LineString(10));
+ benchmark::scalar(
+ c,
+ &f,
+ "native",
+ "st_interiorringn",
+ BenchmarkArgs::ArrayArray(Polygon(10), Int64(1, 10)),
+ );
Review Comment:
Is there a way to guage and know which would have a hole? say `Polygon(500)`?
##########
rust/sedona-testing/src/benchmark_util.rs:
##########
@@ -277,6 +277,8 @@ pub enum BenchmarkArgSpec {
/// Randomly generated linestring input with a specified number of vertices
MultiPoint(usize),
/// Randomly generated floating point input with a given range of values
+ Int64(i64, i64),
+ /// Randomly generated floating point input with a given range of values
Review Comment:
Would fix :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
