petern48 commented on PR #2416: URL: https://github.com/apache/sedona/pull/2416#issuecomment-3424690292
Last thing, I'll ask for you to do, could we add just one more case for `test_is_closed`? In a [previous PR](https://github.com/apache/sedona/pull/2387) of yours, we switched from using `GeometryType` to `ST_GeometryType` as well (https://github.com/apache/sedona/pull/2387/commits/9daec30509bb7517ea5543958613ad932f06373c). https://github.com/apache/sedona/blob/9ea7c23633cf97b30a662465aa061feecfdaa79c/python/sedona/spark/geopandas/geoseries.py#L995-L999 I didn't ask you to add an `M`-dimension test that time since it felt out-of-scope, but this would be a good time to add it now. Ideally, it would be a test case involving a `LINESTRING M` that should result in `True`, since that's what would fail if we used `GeometryType` instead (since it would return `LINESTRINGM` and not match with the. Similar to what I proposed above for `.length()`, you could simply take one of the existing cases that return `True` and add an `M` dimension of `0` to each of the points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
