petern48 commented on code in PR #2416:
URL: https://github.com/apache/sedona/pull/2416#discussion_r2446673502
##########
python/tests/geopandas/test_geoseries.py:
##########
@@ -1462,6 +1462,37 @@ def test_crosses(self):
df_result = s.to_geoframe().crosses(s2, align=False).to_pandas()
assert_series_equal(df_result, expected)
+ def test_geometry_type_with_m_dimension(self):
Review Comment:
Personally, I think it's better to test each of the functions in their own
respective test functions, rather than lump than all together. How about we
remove this test and add tests to the existing `test_crosses`, `test_length`,
and `test_boundary`? We can write slightly more precise tests and there's a
small correctness bug in this one causing [the CI
failure](https://github.com/apache/sedona/actions/runs/18671518097/job/53233436054?pr=2416),
anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
