Kontinuation commented on code in PR #152:
URL: https://github.com/apache/sedona-db/pull/152#discussion_r2380663283
##########
Cargo.toml:
##########
@@ -116,6 +116,17 @@ tokio = { version = "1.44" }
url = "2.5.4"
[patch.crates-io]
+# For R package build on Windows (can be removed when we upgrade to DataFusion
main/51.0.0)
+datafusion = { git = "https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion" }
+datafusion-catalog = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-catalog" }
+datafusion-common = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-common" }
+datafusion-common-runtime = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-common-runtime" }
+datafusion-execution = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-execution" }
+datafusion-expr = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-expr" }
+datafusion-ffi = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-ffi" }
+datafusion-physical-expr = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-physical-expr" }
+datafusion-physical-plan = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-physical-plan" }
Review Comment:
Looks like https://github.com/apache/datafusion/pull/17688 is the fix
required for the R Windows build. I'm fine with this since the other forked
dependencies also take time to be cleared. We can target removing all forked
dependencies once DataFusion 51 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
