paleolimbot commented on code in PR #152:
URL: https://github.com/apache/sedona-db/pull/152#discussion_r2380632812
##########
Cargo.toml:
##########
@@ -116,6 +116,17 @@ tokio = { version = "1.44" }
url = "2.5.4"
[patch.crates-io]
+# For R package build on Windows (can be removed when we upgrade to DataFusion
main/51.0.0)
+datafusion = { git = "https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion" }
+datafusion-catalog = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-catalog" }
+datafusion-common = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-common" }
+datafusion-common-runtime = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-common-runtime" }
+datafusion-execution = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-execution" }
+datafusion-expr = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-expr" }
+datafusion-ffi = { git = "https://github.com/paleolimbot/datafusion.git";,
branch = "local-49-with-patch", package = "datafusion-ffi" }
+datafusion-physical-expr = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-physical-expr" }
+datafusion-physical-plan = { git =
"https://github.com/paleolimbot/datafusion.git";, branch =
"local-49-with-patch", package = "datafusion-physical-plan" }
Review Comment:
I'm not actually sure this is a good idea given that we're in the process of
removing the other patches. If we leave them in we get R binaries for Windows
via R Universe...we can remove them when we update to DataFusion 51, which I
think we'd like to do soon. I'm also not offended if this is too much for right
now (I can just comment out the Windows CI again).
##########
.github/workflows/r-extended.yml:
##########
@@ -0,0 +1,76 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: r-extended
+
+on:
+ push:
+ branches:
+ - main
+ pull_request:
+ branches:
+ - main
+ paths:
+ - 'r/**'
+jobs:
+
+ test:
+ runs-on: ${{ matrix.config.os }}
+ name: ${{ matrix.config.os }} (${{ matrix.config.r }})
+ defaults:
+ run:
+ shell: bash
+
+ strategy:
+ fail-fast: false
+ matrix:
+ config:
+ - {os: ubuntu-latest, r: 'release'}
+
+ env:
+ GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
+ R_KEEP_PKG_SOURCE: yes
+
+ steps:
+ - uses: actions/checkout@v4
+ - uses: r-lib/actions/setup-pandoc@v2
+ - uses: r-lib/actions/setup-r@v2
+ with:
+ r-version: ${{ matrix.config.r }}
+ http-user-agent: ${{ matrix.config.http-user-agent }}
+ use-public-rspm: true
+
+ - name: Use stable Rust
+ id: rust
+ run: |
+ rustup toolchain install stable --no-self-update
+ rustup default stable
+
+ - name: Install dependencies
+ if: matrix.config.os == 'ubuntu-latest'
+ run: sudo apt-get update && sudo apt-get install -y libgeos-dev
+
+ - uses: r-lib/actions/setup-r-dependencies@v2
+ with:
+ extra-packages: any::rcmdcheck
+ needs: check
+ working-directory: r/sedonadb
+
+ - uses: r-lib/actions/check-r-package@v2
+ with:
+ working-directory: r/sedonadb
+ error-on: '"error"'
Review Comment:
This is the primary reason for this workflow: `R CMD check` runs some extra
tests beyond just "the tests" to make sure examples run, documentation is
correct, and some others. Unfortunately we generate some WARNINGs still for
things that CRAN cares about but we don't (perhaps just speaking for
myself)...it would be nice to ignore specific warnings so that other warnings
don't go unnoticed (but perhaps a battle for a different PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
